Events Made Easy › Forums › Bug fixed or feature request implemented › Google Chrome Compatibility
- This topic has 10 replies, 2 voices, and was last updated 13 years, 10 months ago by Franky.
-
AuthorPosts
-
Mon 17 Jan 2011 at 19:09 #42428AnonymousInactive
Google Chrome usage has increased over the past year and in December exceeded 13 percent. I installed Chrome 8.0.552.237 last night to check EME compatibility because of that. The appearance and functionality is identical to Firefox 3.6.13 and IE 6, 7 and 8 with this previously recommended “eme_calendar.php” modification and associated CSS changes:
Starting at Line 177 in “eme_calendar.php” change from:
$full ? $fullclass = 'fullcalendar' : $fullclass='';
// Build the heading portion of the calendar table
$calendar .= "<table class='eme-calendar-table $fullclass'>n".
"<thead>n<tr>n".
"<td>$previous_link</td><td class='month_name' colspan='5'>$month_name $year</td><td>$next_link</td>n".
"</tr>n</thead>n".
"<tr class='days-names'>n".
$days_initials.
"</tr>n";To:
if ($full) {
$fullclass = 'fullcalendar';
$head = "<td class='month_name' colspan='7'>$previous_link $next_link $month_name $year</td>n";
} else {
$fullclass='';
$head = "<td>$previous_link</td><td class='month_name' colspan='5'>$month_name $year</td><td>$next_link</td>n";
}
// Build the heading portion of the calendar table
$calendar .= "<table class='eme-calendar-table $fullclass'>n".
"<thead>n<tr>n".$head."</tr>n</thead>n".
"<tr class='days-names'>n".$days_initials."</tr>n";Without those changes full calendar column widths are irregular, the irregularities depend on cell contents, and the irregularities are different with each browser (they are especially different between Firefox or Chrome and IE). Column widths are uniform regardless of cell contents using any of those browsers with the changes.
Mon 17 Jan 2011 at 21:58 #46320FrankyKeymasterI have the same google chrome version, and the “collspan 7” part with previous/next link in it, causes the prev/next links to come first and then the rest. Which proves that the corresponding CSS you mailed now proves usefull 🙂
Added in trunk, although I’m not too fond of the gray background (I prefer white) and the month title is a bit too bold/big to my liking. But people can change the CSS 🙂
So: implemented
Mon 17 Jan 2011 at 22:25 #46321AnonymousInactiveI was about to suggest before I read this that it might best to leave the background white and not include the shadowbox styling to have a more “plain vanilla” default appearance that users can style themselves. Background shading and other cosmetic preferences not only vary widely between individuals, but suitability also is greatly dependent upon other styling at a website.
The same is true for the month/title styling. It probably will be best to make the default for that more or less like you had it before. My concern was with other issues that caused layout problems and irregular column spacings in various browsers.
Mon 17 Jan 2011 at 22:54 #46322FrankyKeymasterWell, given the CSS in trunk, a small changed one would be much appreciated 🙂
Mon 17 Jan 2011 at 23:35 #46323FrankyKeymasterI did most of it already, would appreciate it if you doublechecked it …
Tue 18 Jan 2011 at 00:26 #46324AnonymousInactiveI just emailed you a modified “events_manager.css” that I did before I saw that you also had done one.
I will check your new one.
Feel free to use whichever one you like best.
Tue 18 Jan 2011 at 00:47 #46325AnonymousInactiveI just looked at your changes. Our end-results look similar. You made changes to both calendars where I didn’t. Your font size is larger within calendar cells. I made the background of the current day a lighter shade of gray.
Either styling is compatible with Firefox 3.6.13, Chrome 8.0.552.237, and IE6/7/8.
Tue 18 Jan 2011 at 09:51 #46326FrankyKeymasterOk, added in trunk 🙂
Btw: I added one thing:
#content table.fullcalendar td {
border:1px solid #000;
}so the top border of the full calendar is also the same border as the rest
Tue 18 Jan 2011 at 13:02 #46327AnonymousInactiveI thought about doing that, but didn’t. Anyway, it looks good now as it is.
Tue 18 Jan 2011 at 14:15 #46328AnonymousInactiveI just noticed that you left these comments in the CSS file:
/* CHANGED SECTION START *************** */
/* CHANGED SECTION END *************** */Tue 18 Jan 2011 at 14:50 #46329FrankyKeymasterout now 🙂
-
AuthorPosts
- The forum ‘Bug fixed or feature request implemented’ is closed to new topics and replies.