- This topic has 9 replies, 2 voices, and was last updated 13 years, 2 months ago by
.
-
Posts
-
While taking some screen clips of the Event Edit screen I noticed a discrepancy in what is displayed in the Event Date fields, for recurring events: sometimes the ‘first’ date and sometimes the ‘last’.
I realized that it might be my data/versions… having created events over time with differing versions – so I created new test data on both live & test sites.
Live site: 4.01
Test site: reinstalled trunk just now
The live site shows the first occurrence date, and
the test site shows the last occurrence date.
The actual event date for a single occurrence of the event is correct in any list and on the calendar – it’s just on the edit screen where this first/last occurrence date appears in its place.
It would make the most sense to me to display the actual single occurrence date that is being edited.
My main concern at this point though is… I need to know how to describe that field for the screen clips I’m taking to document event setup examples for my user.
Thanks, Franky.
Well, I can’t seem to reproduce it here, but it is not really deterministic: for a recurrent series, to show the duration I search for the first event in the database found for that recurrence. It is very well possible that the query returns another one than the “first” event. See the function eme_get_recurrence() in eme_recurrence.php:
$sql = "SELECT event_id FROM $events_table WHERE recurrence_id = '$recurrence_id' LIMIT 1;";maybe I should add “ORDER BY event_start_date” to the query.
Can you try these selects on live and test? Maybe add the column even_start_date to it:
SELECT event_id,even_start_date FROM $events_table WHERE recurrence_id = '$recurrence_id' LIMIT 1;and then the same, adding the ORDER BY to it:
SELECT event_id,even_start_date FROM $events_table WHERE recurrence_id = '$recurrence_id' ORDER BY event_start_date LIMIT 1;I’m guessing the event_id’s will play up on your test site, and the ORDER BY should fix it then.
No response, considering fixed with this change:
Franky,
I forgot to add this as a favorite, so I never got the notification of your post yesterday… just happened to see this now on the overall list.
I’m on my way out at the moment, but will check out your change – tomorrow morning, if not yet later tonight. Thank you.
After trying the SQL tests you suggested, I realize that my original explanation apparently wasn’t clear.
The ‘event date’ is the one displaying incorrect information, not the ‘recurrence date’. The confusing part may be that the recurrence date is displaying IN the event date fields. 🙂
You probably speak multiple languages, so tell me: is it only in English that clarity seems nearly impossible to achieve?
I am about to send you an email with screen clips, which I feel sure will clarify the situation… 🙂
And btw… it’s still morning somewhere, right?
nope, one can say wrong things in a correct way in many languages 🙂 Hmmm … I should be able to put that in words in a better way, but I’m too hungry now, so my first thoughts are always something related with food 🙂
But I thought I understood you, and the SQL I mentioned should fix it (also based on the screenshots you mailed me). Did you try these out?
Clicking on “Reschedule” reschedules the whole recurrent event series, not the one you clicked on. And the event date mentioned then is just one of the occurrences to indicate the duration (and with the change in sql it should always show the first occurrence now).
Hopefully you’ve had dinner by now.
OK… I’ve downloaded the change and it does indeed show the first occurrence date, in the event date field, when Reschedule is clicked. And that makes sense!
That’s as concise as I can get.
Thank you, and my apologies for being so picky about some things. As I think I’ve mentioned before, my client is NOT very computer savvy and I get a LOT of questions from her – so I’m trying to be as prepared as possible.
Plus… I’m just picky by nature. 🙂
- The forum ‘Bug fixed or feature request implemented’ is closed to new topics and replies.