Events Made Easy › Forums › Bug fixed or feature request implemented › Please allow include/exclude like #_EVENTCATEGORYDESCRIPTIONS{1,5}{2,6}
Tagged: EVENTCATEGORYDESCRIPTIONS, EXCLUDE, Include
- This topic has 24 replies, 2 voices, and was last updated 6 years, 11 months ago by Anonymous.
-
AuthorPosts
-
Sat 23 Dec 2017 at 23:05 #57227AnonymousInactive
Hi Franky,
please make it possible to allow include/exclude like #_EVENTCATEGORYDESCRIPTIONS{1,5}{2,6} for the event category descriptions like it is possible for the EVENTCATEGORIES.
Additionally please allow HTML at the descriptions.
Many thanks!
Cheers & Merry Christmas
JoergSat 23 Dec 2017 at 23:14 #57228AnonymousInactiveOf course an automated filtering of descriptions would also be feasible, so when one would include/exclude EVENTCATEGORIES the EVENTCATEGORIESDESCRIPTIONS would automatically respect these filter settings 🙂
I like to add an additional feature request here in regards to categories and it’s descriptions which is ordering. I like to order the appearance of the categories and it’s descriptions. Either sorting could be done on the eme-categories page or via settings at the placeholder so the order at the include/exclude would also be taken as the order for the output of categories and descriptions.
Sun 24 Dec 2017 at 16:33 #57232FrankyKeymasterFor the first feature request, see:
https://plugins.trac.wordpress.org/changeset/1792023/Sorting by exclude is impossible btw … sorting by include is possible, but not now 🙂
Sun 24 Dec 2017 at 16:53 #57233AnonymousInactiveCool thank you 🙂
Looking forward to see sorting one day …Tue 26 Dec 2017 at 13:32 #57235FrankyKeymasterTry this change for cat order:
https://plugins.trac.wordpress.org/changeset/1792545/Wed 27 Dec 2017 at 08:24 #57237AnonymousInactiveHey Franky,
the HTML output is showing the HTML code itself and it looks like that I cannot use #_EVENTCATEGORIES or #_EVENTCATEGORYDESCRIPTIONS at a event description itself?
Would it also be possible to get each cat and description as a list (each cat and description) in a separate row instead or comma separated?
Sorting seems to work…
Cheers
JoergWed 27 Dec 2017 at 10:05 #57238FrankyKeymasterLatest dev should fix the html output.
Also, from the readme:
* Added filters eme_event_categories_sep_filter, eme_event_categorydescriptions_sep_filter, eme_linked_event_categories_sep_filter
These control the separator for #_EVENTCATEGORIES (default: “, “), #_EVENTCATEGORYDESCRIPTIONS (default: “, “) and #_LINKEDEVENTCATEGORIES (default: “, “)Concerning the event description: if you really mean the description (and not the single event format), check the option “Enable placeholders in event notes”
Wed 27 Dec 2017 at 10:38 #57239AnonymousInactiveHTML output works now.
How do I use the new filters?
By simply adding something like this?
add_filter(eme_event_categories_sep_filter,”;”);
add_filter(eme_event_categorydescriptions_sep_filter,”;”);
add_filter(eme_linked_event_categories_sep_filter,”;”);How would I achieve a new line? by <br /> or \n or something else?
And yes using the setting to allow placeholder anywhere fixed my issue (I did not used the setting up to now because you mentioned to be careful with this setting) 🙂
Wed 27 Dec 2017 at 11:09 #57240AnonymousInactiveAs my test using my code above did not work I tested something like this:
function my_eme_separator($my_separator) {
$my_separator=”; “;
return $my_separator;
}
add_filter(’eme_event_categories_sep_filter’,’my_eme_separator’);which gives me a ; as a separator but I didn’t find out how to make a line break.
Wed 27 Dec 2017 at 11:29 #57241FrankyKeymasterYour second attempt for the use of filters is the correct one (wordpress method). Don’t forget to put this in functions.php in a child theme, so when the theme updates your changes aren’t removed.
This should do the line break:
$my_separator=”<br \> “;
Wed 27 Dec 2017 at 11:30 #57242AnonymousInactiveUsing <br> outputs also just <br> and using any other option to make a line break did not work like \n, \n\r, \r, PHP_EOL, <br>, <br \>, <br /> etc.
And I think when using <br> this will not work for the category title as the title (currently) is not supporting HTML at all?
Wed 27 Dec 2017 at 11:44 #57243AnonymousInactive<br /> at least works for eme_event_categorydescriptions_sep_filter
Wed 27 Dec 2017 at 12:10 #57245FrankyKeymasterIndeed, fixed that part now (the html was stripped out, and \n or \r doesn’t show in html output …).
Wed 27 Dec 2017 at 12:41 #57248AnonymousInactiveSo for eme_event_categories_sep_filter & eme_linked_event_categories_sep_filter we cannot use the filter to achieve a line break as separator?
Wed 27 Dec 2017 at 15:16 #57249FrankyKeymasterI think you missed the word “was” in my last post.
Wed 27 Dec 2017 at 15:18 #57250AnonymousInactiveNow I’m confused, as it is not working for me with the category titles.
Wed 27 Dec 2017 at 17:14 #57251FrankyKeymasterYou updated to the latest dev version again?
Wed 27 Dec 2017 at 22:50 #57252AnonymousInactiveTo be extra secure and really have the latest version, I just downloaded again and tested.
But still no luck for the event categories listing…Wed 27 Dec 2017 at 23:18 #57253FrankyKeymasterYou’re correct. Try the newest dev version now, I mixed around 2 lines in events-manager.php
Thu 28 Dec 2017 at 06:20 #57256AnonymousInactiveHey Franky, the separator works like charm now, however can you please re-check sorting for the #_EVENTCATEGORYDESCRIPTIONS please?
Thu 28 Dec 2017 at 07:39 #57257FrankyKeymasterI thought you said sorting worked?
Edit: there was indeed a bug with #_EVENTCATEGORYDESCRIPTIONS{1,5}{2,6} itself, fixed here:
https://plugins.trac.wordpress.org/changeset/1793478/Thu 28 Dec 2017 at 08:52 #57260AnonymousInactiveI’m sorry I didn’t noticed the difference, I was just looking at the categories.
I did not notice that it wasn’t sorting as expected for the descriptions itself.But I checked the most recent dev version and now this is also fixed.
This topic is solved 🙂
Many thanks Franky!
Fri 29 Dec 2017 at 10:09 #57271FrankyKeymasterBtw: I added options in EME for these 3 too, the use of filters is not that userfriendly …
Fri 29 Dec 2017 at 10:23 #57272AnonymousInactiveI found the setting, many thanks, but I could not find the strings for translations yet.. maybe it will just take a little time.
Tested and I confirm it works 🙂
Many thanks!
Fri 29 Dec 2017 at 10:55 #57273AnonymousInactiveTranslations are made as well…
-
AuthorPosts
- The forum ‘Bug fixed or feature request implemented’ is closed to new topics and replies.