Events Made Easy Forums Bug fixed or feature request implemented EME_PLUGIN_URL breaks secure backends

Viewing 16 posts - 1 through 16 (of 16 total)
  • Author
    Posts
  • #42222
    Anonymous
    Inactive

    Fantastic to see this great plugin being maintained. One small request:

    in v3.2.7, can line 34 of events-manager.php please be changed to

    define('EME_PLUGIN_URL', plugins_url('', __FILE__) . '/');

    …otherwise users get a “Load only secure content?” pop-up on every screen of the backend on sites where FORCE_SSL_ADMIN has been set to true in wp-config.php. Apparently, we should all stop using WP_PLUGIN_URL etirely due to the fact that it breaks secure admins.

    Thanks! Hope this is helpful.

    #45327
    Franky
    Keymaster

    Thanks for the heads-up. Has been changed in the trunk version!

    #45328
    Anonymous
    Inactive

    Excellent – thanks for being so responsive!

    #45329
    Anonymous
    Inactive

    I made the changes above to fix the same issue but I am now getting the following fatal error:

    Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in domain.org/html/wp-content/plugins/events-manager-extended/events-manager.php on line 1010

    #45330
    Anonymous
    Inactive

    Attempt 2: So making the change via FTP did not result in the error but I am still getting the SSL warnings.

    #45331
    Franky
    Keymaster

    Well, try to use the latest version, the change is already in there.

    #45332
    Anonymous
    Inactive

    I’m currently running Version 3.2.12. I see it listed as the newest stable release.

    #45333
    Franky
    Keymaster

    Well, this is in there:

    define('EME_PLUGIN_URL', plugins_url('',plugin_basename(__FILE__)).'/');

    and should be ok …

    #45334
    Anonymous
    Inactive

    This is from the zip file I just downloaded off this site.

    <?php

    /*

    Plugin Name: Events Manager Extended

    Version: 3.2.12

    Plugin URI: http://www.e-dynamics.be/wordpress

    Description: Manage events specifying precise spatial data (Location, Town, etc).

    Author: Franky Van Liedekerke

    Author URI: http://www.e-dynamics.be/

    */

    /*

    Copyright (c) 2009, Davide Benini. $Revision: 1 $

    Copyright (c) 2010, Franky Van Liedekerke.

    This program is free software; you can redistribute it and/or

    modify it under the terms of the GNU General Public License

    as published by the Free Software Foundation; either version 2

    of the License, or (at your option) any later version.

    This program is distributed in the hope that it will be useful,

    but WITHOUT ANY WARRANTY; without even the implied warranty of

    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License

    along with this program; if not, write to the Free Software

    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

    */

    /*************************************************/

    // Setting constants

    define(‘EME_DB_VERSION’, 11);

    define(‘EME_PLUGIN_URL’, plugins_url(”,plugin_basename(__FILE__)).’/’); //PLUGIN DIRECTORY

    define(‘EME_PLUGIN_DIR’, ABSPATH.PLUGINDIR.’/’.str_replace(basename( __FILE__),””,plugin_basename(__FILE__))); //PLUGIN DIRECTORY

    define(‘EVENTS_TBNAME’,’dbem_events’); //TABLE NAME

    define(‘RECURRENCE_TBNAME’,’dbem_recurrence’); //TABLE NAME

    define(‘LOCATIONS_TBNAME’,’dbem_locations’); //TABLE NAME

    define(‘BOOKINGS_TBNAME’,’dbem_bookings’); //TABLE NAME

    define(‘PEOPLE_TBNAME’,’dbem_people’); //TABLE NAME

    #45335
    Franky
    Keymaster

    yes??? It’s there:

    define('EME_PLUGIN_URL', plugins_url('',plugin_basename(__FILE__)).'/'); //PLUGIN DIRECTORY

    #45336
    Anonymous
    Inactive

    I don’t know much about PHP but these two lines are not identical. Either way the fix listed in this post is not working and I would like to be able to turn map integration on again.

    define(‘EME_PLUGIN_URL’, plugins_url(”, __FILE__) . ‘/’); Line in post

    define(‘EME_PLUGIN_URL’, plugins_url(”,plugin_basename(__FILE__)).’/’); Line in file

    Here are the console errors google chrome logs when I have map integration enabled.

    The page at https://www.simpletruthfoundation.org/about-us/support ran insecure content from http://maps.google.com/maps/api/js?v=3.1&sensor=false&callback=loadGMap.

    The page at https://www.simpletruthfoundation.org/about-us/support ran insecure content from http://maps.gstatic.com/intl/en_us/mapfiles/api-3/1/14/main.js.

    The page at https://www.simpletruthfoundation.org/about-us/support ran insecure content from http://maps.gstatic.com/cat_js/intl/en_us/mapfiles/api-3/1/14/%7Bcommon,util%7D.js.

    The page at https://www.simpletruthfoundation.org/about-us/support ran insecure content from http://maps.googleapis.com/maps/api/js/AuthenticationService.Authenticate?1shttps%3A%2F%2Fwww.simpletruthfoundation.org%2Fabout-us%2Fsupport&callback=_xdc_._6xsqn6&token=55824.

    #45337
    Franky
    Keymaster

    The lines are not identical, the version given in the released files is better.

    The problem here is that this is related to the google map service, not your own URL’s. The site at maps.google.com can’t be used over ssl (https), so I can’t change that fact. If you want https for google maps, you have to pay google for it: http://code.google.com/apis/maps/faq.html#ssl

    #45338
    Anonymous
    Inactive

    Thanks I had already looked into that and it’s a minimum of fee $10,000. Not even remotely worth the cost. My thought was why is this code called on every page of the site when in reality it on needs to be executed on just a few pages which I have no need to force SSL on. Since I can see this plugin being used to manage and integrate with an e-commerce system to sell tickets to events, getting it to work on a site that has SSL on some pages could really be beneficial.

    #45339
    Franky
    Keymaster

    Well … I’ll try putting the javascript in the body of the page, if that works I can load it only when needed, otherwise maybe I can add an option so you can define on which pages you want the google maps api to be loaded, I see no other way around it …

    #45340
    Franky
    Keymaster

    I’ve committed some code to svn trunk that should resolve this, as in the changelog:

    “the google map javascript code will now only get loaded if/when needed at the bottom of pages, and no longer always at the top”

    The diff: http://plugins.trac.wordpress.org/changeset/324983/events-manager-extended/trunk

    #45341
    Anonymous
    Inactive

    Thinks for making those improvements. I tested it out on my clients site and everything is working great.

Viewing 16 posts - 1 through 16 (of 16 total)
  • The forum ‘Bug fixed or feature request implemented’ is closed to new topics and replies.
Scroll to Top